Add Elixir/Erlang version feature and respective feature test#138
Add Elixir/Erlang version feature and respective feature test#138matiaswilner merged 4 commits intomasterfrom
Conversation
eldano
left a comment
eldano
left a comment
There was a problem hiding this comment.
I like this approach as it looks similar to iex.
I also thought about displaying this info in a more global place like near the heading of the page. Just wondering if you considered other cases too
| end) | ||
| end | ||
|
|
||
| feature "visitor gets Elixir and Erlang version", %{session: session} do |
There was a problem hiding this comment.
While this is ok, I don't know if we want to add too many feature tests as these are slow. In particular, I'm not very concerned about introducing a regression here but this is questionable. Thoughts? cc/ @grzuy
There was a problem hiding this comment.
Yup, generally agree.
I think in this particular case, this a functionality that can be left out of the feature test coverage without losing a lot given the implementation is quite simple and straightforward, meaning there's low probability of introducing a bug, and if still buggy, it would be something can be easily detected visually by just rendering the page.
@matiaswilner Thanks anyway for trying to have coverage for this, better to err on the side of coverage than not.
-Delete feature test -Add class to style version-info div -Improve code-styling issue
| @command_output css("#commandOutput") | ||
| @suggestions_list css("#suggestions-list") | ||
| @documentation_output css("#documentation-output") | ||
| @version_info css("#version-info") |
There was a problem hiding this comment.
Now this module attribute is not needed anymore. Thanks for removing that test!
3 participants
No description provided.